-
-
Notifications
You must be signed in to change notification settings - Fork 398
Add install script and update install instructions #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying the new installer on my macOS machine I've found two minor issues. I've proposed a bug fix on the JSON issue using the new (for me!) GitHub feature for suggesting changes.
Let me know what you think..
Co-Authored-By: Maurizio Branca <[email protected]>
Co-Authored-By: Maurizio Branca <[email protected]>
Co-Authored-By: per1234 <[email protected]>
Co-Authored-By: per1234 <[email protected]>
Co-Authored-By: per1234 <[email protected]>
Co-Authored-By: per1234 <[email protected]>
Co-Authored-By: per1234 <[email protected]>
Co-Authored-By: per1234 <[email protected]>
Co-Authored-By: per1234 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, also on behalf of @mastrolinux :)
This PR adds an
install.sh
script based on the one fromhttps://github.com/Masterminds/glide
to allow newcomers to simply do:to install the CLI.
It also updates the README accordingly, showing the various supported install methods. The markdown was also fixed to leverage Github's rendering helpers and show a nice output in the examples.